Google Git
Sign in
chromium / chromium / src / ad8db89e88b51eaae8b50608962638dab8a72cf5
commitad8db89e88b51eaae8b50608962638dab8a72cf5[log] [tgz]
authorDavid Maunder <davidjm@chromium.org>Mon Apr 24 16:14:27 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 24 16:14:27 2023
treee5669b1bebbe0e67c5918fb922199eeb02f341ca
parentdf38d56cdc04233d6b8eb2f7984cd08aae3fe689 [diff]
Remove File member in FilePersistedTabDataStorage

The File object is created on the constructor in StorageRequest
which is not necessary. This has been linked to Jank. This CL removes
the member and just acquires the File object on demand. The File is
also removed from hashCode() and equals() because it is not necessary
there. The File is a function of the Tab ID and Data ID which
hasCode() and equals() already includes.

Bug: 1402257
Change-Id: Ic64cc7c67e7b864880caaa4193a260675552e398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454615
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1134643}
2 files changed
tree: e5669b1bebbe0e67c5918fb922199eeb02f341ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.