commit | adb8ea7be9dd165ae37d6af8b936d61af1a11f41 | [log] [tgz] |
---|---|---|
author | Ben Reich <benreich@chromium.org> | Fri Sep 09 05:29:17 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 09 05:29:17 2022 |
tree | d33bf06819c843553e0fa52e72cc273a6465e55c | |
parent | 92d727424a86243abbfd1bd34d5885db5fdc2683 [diff] |
[FilesTrash] Set extended attribute for low-disk cleanup In a low-disk space scenario the Trash subdirectories represent a unit of deletion that should be prioritised over the remainder of the user's profile. To enable this, set an xattr for the user.TrackedDirectoryName of both "trash_files" and "trash_info" to represent these locations. The subdirectories have been chosen as DriveFS exposes their trash implementation via FUSE and explicitly disable the ability to delete the trash folder, so target the subdirectories instead. NOTE: In unit tests the temp directories are created on /tmp which is backed by a tmpfs filesystem. Unfortunately (without some kernel flags being flipped) xattr are not settable on this filesystem. So don't set them for unittests, this functionality will be tested via tast instead once chromium has rolled into chromeos. Bug: b:243879434 Test: unit_tests --gtest_filter=TrashIOTaskTest* Test: deploy chrome then getfattr -d -m ".*" ~/MyFiles/.Trash Change-Id: Ie591dd073f4475e284b5b7b7fd17d37a77126faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881625 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1044939}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.