Google Git
Sign in
chromium / chromium / src / adde4881f377c8c4bc5d39c527daf30ad47fdaa4
commitadde4881f377c8c4bc5d39c527daf30ad47fdaa4[log] [tgz]
authorJohn Chen <johnchen@chromium.org>Tue Dec 03 16:58:16 2019
committerCommit Bot <commit-bot@chromium.org>Tue Dec 03 16:58:16 2019
tree9f9e21bc1c180c9b8cc3d8c5094e738002e9112b
parent094d246a3795336a126d9382a1e598b7e1bf335d [diff]
[ChromeDriver] Workaround DevTools fullscreen issue

Add some workaround code while setting browser window to fullscreen
mode, to work around an issue in DevTools fullscreen command. In
particular, call document.documentElement.requestFullscreen() to ensure
that document.webkitIsFullScreen returns the correct values. All WPT
tests related to fullscreen now pass.

Also made an adjustment to WPT set_window_rect/set.py
test_fully_exit_fullscreen, which was using a width below the minimum
supported by Chrome.

Bug: 982071
Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947816
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721019}
4 files changed
tree: 9f9e21bc1c180c9b8cc3d8c5094e738002e9112b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .