Google Git
Sign in
chromium / chromium / src / adfd841489e2b0c573a11ea4d127cafa3b7ca4da
commitadfd841489e2b0c573a11ea4d127cafa3b7ca4da[log] [tgz]
authormlcui <mlcui@google.com>Thu Apr 04 23:26:40 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 04 23:26:40 2024
tree6f48f53f04f1f4f27601bcf8b9722ba43b684a77
parentd7432655360d90bdd55ae4245e6cf7fd37070503 [diff]
Move controller and results publisher logic out of `SearchProviderAsh`

Previously, `SearchProviderAsh` acted as a `SearchControllerRegistry` as
well as an interface to interact with a single remote
`SearchController` - implementing `SearchResultsPublisher` to receive
requests for the associated remote `SearchController`.

We are planning to allow for multiple `SearchControllers` in upcoming
code, which would require the same `SearchResultsPublisher` logic
currently in `SearchProviderAsh`.

Separate the `SearchController` and `SearchResultsPublisher` out into a
new class, `SearchControllerAsh`. At the moment, `SearchControllerAsh`
contains a direct move of some of the methods of `SearchProviderAsh`.

Due to this direct move, `SearchControllerAsh` is not guaranteed to be
bound (for example, immediately after construction). Future CLs will
refactor `SearchControllerAsh` to ensure that it is always bound.

Googlers: See http://go/cahfh for a design doc explaining this chain of
CLs, and http://go/cahfh#heading=h.vyp6fypnoqpz for more details about
this change, including a diagram of the before and after.

Bug: b:326147929
Change-Id: I100129c45f47a7f8399cd0ca497f31913d4ce57a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5360274
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>
Cr-Commit-Position: refs/heads/main@{#1282826}
6 files changed
tree: 6f48f53f04f1f4f27601bcf8b9722ba43b684a77
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.