[Shelf] Speculative fixing for ShelfView::PrepareForDrag Have not found a way to reproduce the issue on a real device yet. But by reading code, I noticed that the data members for the in-flight context menu model request are not reset properly when a shelf item is removed. This CL fixes this issue by resetting `context_menu_callback_` and `item_awaiting_response_` in `ShelfView::PrepareForDrag()` if the removed item has an active request for context menu model. Add a unit test to verify this scenario. Bug: 1322950 Change-Id: I6b9149ea9eb1bdb91b052b9989b1d485811b1d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639442 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1001712}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.