commit | e0a2c42fe5e35bd8dd458a584dc8acdd126aea23 | [log] [tgz] |
---|---|---|
author | Tom Sepez <tsepez@chromium.org> | Wed Sep 20 16:13:08 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 20 16:13:08 2023 |
tree | 88c1c070c6dff5c75d82e8f0cfc47fe2959e5af6 | |
parent | b9b9f2d22fa62cc30fd50a15d224f57406e2d099 [diff] |
Explicitly initialize raw_ptrs in DialogModelHostField. Although this happens automatically for most impls, should this code run under raw_ptr's NoOpImpl, the initialization will not happen as expected. This is problematic given a 'return {}' in FindDialogModelHostField(). Change-Id: I6c4289c4d29ad5f477569f42bb1ed8716a15ede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876182 Reviewed-by: Elly FJ <ellyjones@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1199047}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.