Google Git
Sign in
chromium / chromium / src / ae460cf25e1209690330031b632768b67afd0a6d
commitae460cf25e1209690330031b632768b67afd0a6d[log] [tgz]
authorL. David Baron <dbaron@chromium.org>Tue Feb 20 22:19:12 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 20 22:19:12 2024
treed5df9f8ca304e182db1cbdc10bd0c27045c961c6
parentf518f68d8e43ad585afd815d464793a407ffd9fa [diff]
Make type argument to init*Event for MutationEvent and TextEvent non-optional.

For both events, this matches a WebKit change made in
https://github.com/WebKit/WebKit/commit/6649c3ddc345f2a53920958f5a321e70a09cbf00

For MutationEvent this also matches the Gecko IDL:
https://searchfox.org/mozilla-central/source/dom/webidl/MutationEvent.webidl
(Gecko does not implement TextEvent.)

For TextEvent this matches the proposed spec and tests in
https://github.com/w3c/uievents/pull/362 and
https://github.com/web-platform-tests/wpt/pull/44472 .

For MutationEvent I suppose this matches the ancient spec in
https://www.w3.org/TR/DOM-Level-2-Events/#events-Events-MutationEvent
although that spec uses OMG IDL since it predates WebIDL, so it's
not necessarily clear.

Other events were previously fixed in
https://crrev.com/5e13fac3f90eaed55ceac453466ea3610d9f8b5c and
https://crrev.com/035ad13ca11618ee85f9b32e45a36ddae6104424 .

Fixed: 324276564
Change-Id: I38297ca4982a5f009759bb40d3eded78dbc9ea36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280630
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262947}
3 files changed
tree: d5df9f8ca304e182db1cbdc10bd0c27045c961c6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.