| commit | ae4838c90c01ea69d96f7f6fff14da46fda70011 | [log] [tgz] |
|---|---|---|
| author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Wed Aug 06 20:41:48 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 06 20:41:48 2025 |
| tree | 7314071cae294da62ddcfcfd4c619f947b2520e5 | |
| parent | 4bee4dc7c9d7978f74471f6b9628aeda6616a8cb [diff] |
Revert "Reland "Focus on the search box when entering History page on large device with keyboard"" This reverts commit 0e949861f5da968264326b7574d8273b0a2d5dd7. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5142442044030976 Sample build with failed test: https://ci.chromium.org/b/8707304509961108897 Affected test(s): [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.history.HistoryTest#testHistorySyncPromoHeader_withHistoryRecord](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.history.HistoryTest%23testHistorySyncPromoHeader_withHistoryRecord?q=VHash%3A9db0946a972712b3) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5142442044030976&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6756927&type=BUG Original change's description: > Reland "Focus on the search box when entering History page on large device with keyboard" > > UI proposal: > https://docs.google.com/document/d/1vkaXYnlM23xOb0HOy71v28lLQeoJ5pKbP98Ca3ku76c/edit?tab=t.0 > My design proposal: go/history-page-improvement-llf-devices > > In the reland cl, 1. I remove the normal view and leave only search view > for LLF devices 2. I remove the "go back" button in search view 3. I > change the headers' display logic > > Before change: > http://screencast/cast/NjMwMTM2NTg3MjYyMzYxNnxmNWM5YTkyNi1lNg After > change: > https://screencast.googleplex.com/cast/NjY5MTUwNDMyNzIyOTQ0MHwxNDg5ZWFkYS02MQ > > This is a reland of commit cd719ede24d171049023dd63acc4595e95ea9c7b > > Original change's description: > > Focus on the search box when entering History page on large device with keyboard > > > > Currently when entering the chrome://history, the first page pop up is > > the history title with a magnifier button on the side. This isn't a good > > UX and we want to make the search box pop up first. > > > > Bug: 349021502 > > Signed-off-by: Fuhsin Liao <fuhsinliao@google.com> > > Change-Id: I52486946853de89d96829269e9348bf48eed8e92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6703931 > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > > Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1485321} > > Bug: 349021502 > Cq-Include-Trybots: luci.chromium.try:android-15-tablet-x64-rel > Change-Id: I21b41f84ad04326731fe1169bd7a5cc4bfbb1c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6756927 > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Commit-Queue: Fuhsin Liao <fuhsinliao@google.com> > Cr-Commit-Position: refs/heads/main@{#1497378} > Bug: 349021502 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I4fd66920e5bfb5aa2c6d69201966ccc4762f7c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822619 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shu Yang <shuyng@google.com> Owners-Override: Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#1497824}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.