Consume appropriate system bar insets when consuming caption bar insets

Caption bars are part of window insets - if one type of system bar insets are consumed, without also applying that change to the rest of the system bars, the InsetObserver may end up communicating misleading insets to future observers and consumers.

For example, suppose a caption bar of 100 pixels overlaps with a status bar of 50 pixels. Both bars are positioned from the top of the screen, so the caption bar extends 50 pixels below the bottom of the status bar. If an insets consumer consumes the caption bar inset of 100 pixels, but then leaves the status bar insets untouched, future consumers will believe they are in a window with only a 50 pixel status bar, and react accordingly, when in reality there should be no top inset, as the status bar is entirely within the bounds of the caption bar inset.

This change creates a subclass for InsetsRectProvider to account for caption bars, though it could be tweaked to be general to all system bars. When consuming insets, the consumed insets are also subtracted from the systemBars() insets, which automatically applies the change across the rest of the systemBars() insets (including status and navigation bars).

Bug: 394416443
Change-Id: Ie5a2a266c1242487bc79a3613774ec71e205642b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6331298
Commit-Queue: Charles Hager <clhager@google.com>
Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432838}
5 files changed
tree: 17dda762be09a987ccc6e3beeec07d2c3180709c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.