Google Git
Sign in
chromium / chromium / src / ae9bc1de3ae10c40eda39c91146f8d6f624c7675
commitae9bc1de3ae10c40eda39c91146f8d6f624c7675[log] [tgz]
authorSammie Quon <sammiequon@chromium.org>Thu Feb 22 18:46:59 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 22 18:46:59 2024
tree093ef533009f1c842864f97b39c7b7ffba9653d4
parent576bb779b65e26511e0c9d92d17623119cd4153a [diff]
float: Fix crash when using always on top window

Always on top windows are not managed by tablet mode window manager so
use DefaultState. There was an assumption that DefaultState is used
for clamshell only, leading to a crash. This CL removes that assumption.

And for consistency we exit float state when entering always on top, as
currently we cannot enter float state when already always on top.

We may want to address b/325282588 in the future, but for a short term
crash fix, this should be sufficient.

Bug: b/317064996
Test: ash_unittests TabletWindowFloatTest.FloatStateToAlwaysOnTop
Change-Id: Ib73d5406622a0557716dd9878af3add9b09fb1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280633
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1264106}
3 files changed
tree: 093ef533009f1c842864f97b39c7b7ffba9653d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.