commit aea61c773df752ad5fa91fd1bb8a96fdb3b3a316
author wutao <wutao@chromium.org> Fri Jun 03 23:58:55 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 03 23:58:55 2022
tree 98477af0222c7be4f7fe6bdb99815a27582058a3
parent a60d4be9a5a534bcf70fda407dae08e998807175

[M103 merge] libassistant-dlc: Only load library once

Currently when enabling Assistant, we will reload the libassistant.so.
This is not necessary and we only need to load the library once.

By loading the library multiple times, it also caused unexpected
behavior by our assistant code or libassistant code. Some stack trace
can be found in the bug. It is not clear why that happens ATM, which
will require more investigation. Some assumption is that we do not
handle the life cycle of http_connection correctly.

I could not reproduce the bug with this patch or without DLC related
code at all. E.g. without this patch, I could repro about 30 times of
toggling. With this patch, I have tried 500 times, I could not repro.
The only difference is that we only load the library once.

We have a plan to write a tast test to verify this: b/233837276.

(cherry picked from commit 67ac1e5edf03ca54d57528edd7013dda2a4d4649)

Bug: b:233157402
Test: manual
Change-Id: I81e1c33cca733efc5361867a531c7e823e649572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3665842
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1008426}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3689359
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#532}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}