Google Git
Sign in
chromium / chromium / src / aebef493aa330deebf6d84272e54bec79154ba38
commitaebef493aa330deebf6d84272e54bec79154ba38[log] [tgz]
authorSergio Villar Senin <svillar@igalia.com>Thu Feb 07 14:10:02 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 07 14:10:02 2019
treefaaa774eefaa0a477127feab2b8498d433ca3cfb
parente85090e836347b4805b9c48b912cf5a76149ae38 [diff]
Remove GaiaCookieManagerService dependency from ChildAccountService

ChildAccountService was observing changes the list of gaia accounts in
the cookie jar in order to notify its observers. We can achieve the
same behaviour by observing IdentityManager instead.

Apart from that the call to GaiaCookieManagerService::ListAccounts()
was successfully replaced by
IdentityManager::GetAccountsInCookieJar(). This allows us to
completely remove the dependency on GaiaCookieManagerService.

Bug: 921007
Change-Id: I7acc064c65ae2d61eb9d807e08183f2ee30e5183
Reviewed-on: https://chromium-review.googlesource.com/c/1409010
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629957}
2 files changed
tree: faaa774eefaa0a477127feab2b8498d433ca3cfb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .