commit 35152ffc73e51d2f290af7d632d2297ed942cf29
author David Roger <droger@chromium.org> Thu Apr 25 14:46:08 2019
committer Commit Bot <commit-bot@chromium.org> Thu Apr 25 14:46:08 2019
tree 475ecd1eae50280cd751facbe321ad73272b0186
parent 4d733c8f014538c54f0ad83b9d96521b2554a69a

[signin] Pass ProfileAttributesStorage in SigninProfileAttributesUpdater constructor

g_brower_process()->profile_manager() returns null during profile
destruction, even though the profile manager has not been destroyed yet.

Instead of retrieving the ProfileAttributesStorage from g_browser_process,
this CL passes it in the constructor.

Note that, although ProfileAttributesStorage supports weak pointers, it
is actually not necessary to use them here, because the storage outlives
the SigninProfileAttributesUpdater anyway.

As a side effect, the AccountConsistencyModeManager is no longer always
created at the profile creation (because SigninProfileAttributesUpdater
now sometimes early-returns before creating it).
This CL changes AccountConsistencyModeManagerFactory to always instantiate
the service.

Bug: 953596
Change-Id: Ib8bfaf8eed1fbf8b121e28737b0c665e19f818a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578739
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654019}