| commit | af42e1a74a75dd03800535623ff2ec22b94c9da7 | [log] [tgz] |
|---|---|---|
| author | Xida Chen <xidachen@chromium.org> | Thu Jan 28 16:03:08 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 28 16:03:08 2021 |
| tree | 4158232fb4c1e7bb4cdcc45f0940c8b3bf9cb586 | |
| parent | 44d261a8c327f58e6d1e7f7950145982c148cc0d [diff] |
Fix a potential crash in BackgroundColorProxyClient::Paint This CL fixes a potential crash in composite bgcolor animation. Specifically in BackgroundColorPaintWorkletProxyClient::Paint, we have a DCHECK to ensure that the size of the |animated_property_values| is 1. However, this DCHECK can be violated in some cases. For example, we have a bgcolor animation running on the compositor thread with a janky RAF in the script. In this case, when the bgcolor animation is ended, we might have a frame that is already scheduled by RAF, in this case when we reach the Paint() function, the |animated_property_values| is empty because the animation already ended. Bug: 1170348 Change-Id: I25e5fa55cac950732fc9a4b72bc8a668ca0f604d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650127 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#848119}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.