Move extension loading logic to ReadAnythingService.

This CL makes two changes:
(1) It removes dead code from ReadAnythingCoordinator
(2) It moves the extension loading logic to ReadAnythingService.

The logic for (2) is moved wholesale. In the process this fixes 3 bugs
and identifies a fourth.
Bug 1: The timer to uninstall extensions was repeating when it should
have been one-shot.
Bug 2: If multiple windows are simultaneously using read anything, and
the side panel is closed on one window, the extension will be
uninstalled for the whole profile.
Bug 3: If any window is closed, the extension will be uninstalled for
the whole profile.
Bug 4: If the extension is installed but the feature is disabled (which
can happen for example if the previous run of chrome installed the
extension and then crashed), the logic to uninstall the extension will
never trigger. Documented at issue 362787711

Previously, if multiple windows were simultaneously
using read anything, then the extension could be uninstalled while the
side panel was still in use.

Bug: 355485153, 362787711
Change-Id: If94eebb46310cd5ae6f2ebc3a18fe8d7715710e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801375
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350530}
10 files changed
tree: 66c715b915cc777cd531d0b0b2753e60c2acce85
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.