Google Git
Sign in
chromium / chromium / src / 70c98c67f89bb4b16b10822b45c3be4a294a5d7f
commit70c98c67f89bb4b16b10822b45c3be4a294a5d7f[log] [tgz]
authorMenghan Yang <myuu@google.com>Fri Jan 31 10:12:17 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 31 10:12:17 2025
tree81e53e3ea1828a75f03557279967064e2bca1f28
parent98a48933f37397b53000410477b55b5876f2da92 [diff]
[Android][Signin] Update profile lock dialogs margin and buttons layout

This CL makes the new profile lock dialog use stacked buttons instead of
a one line button bar, to improve consistency with the other layouts in
the sign-in flow.

It also makes the dialogs layout use horizontal margins only if
UNO_FOR_AUTO is enabled, and only for the lower subviews of the dialogs,
instead of setting a padding on the whole layout without flag guarding.
This fixes the margin for the progress bar under the illustration which
should take the full width of the dialog.

See https://crbug.com/367329904#comment14 for screenshots

Bug: 367329904
Change-Id: Ib13885de60720f6d7da4e2544d090ef7e28f8a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6212623
Commit-Queue: Menghan Yang <myuu@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413982}
8 files changed
tree: 81e53e3ea1828a75f03557279967064e2bca1f28
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.