Google Git
Sign in
chromium / chromium / src / afbdead50529d90ec60918ac1add1e7c0c3eb36a
commitafbdead50529d90ec60918ac1add1e7c0c3eb36a[log] [tgz]
authorBruno Braga <brunobraga@google.com>Wed Dec 27 09:21:33 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 27 09:21:33 2023
treec2c365ab01560ea57b3d99ffc73e01adce088aec
parent2b4438aa8fa4ed02ce3f972039727daf3a34440f [diff]
[mullet m2] Extend and use the current CreateInferred labels.

By making this change we push the label generation logic almost
completely to CreateInferredLabels. This CL achieves that by:

1. Using a set of hard code fields to generate labels from, as opposed
to what is present in the form.
2. Updating the priority order of fields to generate labels.

The two changes above guarantee that ADDRESS_HOME_LINE1 is adde for
every address field that does not contain it and that FULL_NAME is
added otherwise.

The change changes are required because now the label that are returned
changed. This is not a problem but an improvement, basically we favour
FULL_NAME over ZIP_code etc.

DEMO: https://screencast.googleplex.com/cast/NjAwNzQ1Mzc0MDE3MTI2NHxiZDI4MmQ0Zi1hZA

Bug: 1459990
Change-Id: I3b7fdabd5868835d8cf5d904cf5d90a45a26c9d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5149629
Commit-Queue: Bruno Braga <brunobraga@google.com>
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1241120}
6 files changed
tree: c2c365ab01560ea57b3d99ffc73e01adce088aec
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.