Google Git
Sign in
chromium / chromium / src / aff35e93e042a8b331fe2accec95bf014bf5416f
commitaff35e93e042a8b331fe2accec95bf014bf5416f[log] [tgz]
authorScott Yoder <scottyoder@google.com>Fri Nov 03 03:12:25 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 03 03:12:25 2023
tree5ea64b37f5eb5ed1a6bd338b5102206c13d38635
parentc9e8456beea9789c3aefaf66bd1f57807a48389c [diff]
[ios] Fix issues related to focus/defocus omnibox on NTP

This change fixes several issues related to focusing and defocusing the
omnibox / fakebox on the NTP:
 * When the feed is disabled or the DSE changed (which might hide the
   feed), the omnibox should be defocused properly and the content
   offset should not be able to be set beyond the end of the content
   - this could happen if the content gets shorter due to the feed
   disappearing, for example.
 * with Large Fakebox, there are several sequences relate to defocus
   and the fake toolbar needs to be shown and hidden at the right time.
   This fixes an issue where it appeared before the omnibox's animation
   had finished, but ensures that the alpha gets reset when the view is
   shown.
 * fixes another issue related to the calculation of whether the scroll
   position is at the top, and floating point math

Fixed: 1468254, 1498217
Change-Id: Id8564fca7865ff0172b6511c89fc1e6810b6b10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5000208
Commit-Queue: Scott Yoder <scottyoder@google.com>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1219297}
3 files changed
tree: 5ea64b37f5eb5ed1a6bd338b5102206c13d38635
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.