commit | b00366f14c729a20f11d6d09cf6b5a486caf9d12 | [log] [tgz] |
---|---|---|
author | Shakti Sahu <shaktisahu@chromium.org> | Wed Aug 14 19:45:06 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 14 19:45:06 2024 |
tree | 111ae8a04501605a059f1bbfe1157e307362f8e4 | |
parent | 1f1794f29da58c3cda259353fdf1b8687dbddd2c [diff] |
Reland "[iOS TG Sync] Implement IsSaveableNavigation for iOS" This is a reland of commit ecc4f43dd48973da67cab2062e41a102d69ee431 There was a problem with rebase which declared kChromeUINewTabURL twice. The subsequent patchset fixes that. Original change's description: > [iOS TG Sync] Implement IsSaveableNavigation for iOS > > This CL adds various conditions to the navigation to determine > whether a navigation should be synced. This is intended to be a > mirror of the existing TabGroupSyncUtils::IsSaveableNavigation on > desktop and android. > > The next CL https://chromium-review.googlesource.com/c/chromium/src/+/5788102 > filters out unsupported schemes from syncing and replaces them > with an NTP wherever required. > > This also required slight change in signature of > FakeNavigationContext::SetWebState to accept a pointer instead > of std::unique_ptr. > > Bug: 359726089 > Change-Id: Ic41cb3f4a8c5a6d24a4e99cf4b1f955e59e54f0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5787832 > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1341761} Bug: 359726089 Change-Id: I492f543cc9ed99f714de124494eb759943d41ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5788088 Reviewed-by: Ali Juma <ajuma@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1341875}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.