Google Git
Sign in
chromium / chromium / src / b0595cf4b94ccd57cdb710c17a75a9f9a391514d
commitb0595cf4b94ccd57cdb710c17a75a9f9a391514d[log] [tgz]
authorAzeem Arshad <azeemarshad@chromium.org>Thu Dec 19 03:21:53 2019
committerCommit Bot <commit-bot@chromium.org>Thu Dec 19 03:21:53 2019
tree3e1433a7b75b8a8d97995000a7012452053e1344
parent73719d8ec53d79918b965b3950529b922e5bbb0c [diff]
[Network Settings] Fix quick settings mobile data toggle animation

This CL fixes issue with "Mobile Data" toggle animating to the on
position when opening the menu instead of appearing in the on state
immediately. The issue was caused because the mobile data header view
always initializes with the toggle off. The correct value is updated
immediately after initialization. But this code path uses the toggle's
AnimateIsOn method that starts an animation. Fixed this by setting
correct initial state for mobile header view.

Fixed: 1020722
Change-Id: I8c17ce28b09b2506221fcbcbf472f80d44f67006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975111
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726241}
1 file changed
tree: 3e1433a7b75b8a8d97995000a7012452053e1344
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .