commit | b066fe063c72055dcd59f244e201349233df34b0 | [log] [tgz] |
---|---|---|
author | Kalvin Lee <kdlee@chromium.org> | Wed Nov 09 03:43:46 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 09 03:43:46 2022 |
tree | c3f19982ffc6383453ff546dc2b274cdba8fa7ab | |
parent | b034cdeec3aa7db6002180234a2a06848738dc63 [diff] |
nacl-toolchain: Logically decouple BRP from PA-E This CL is mainly a no-op, surfacing the GN arg that explicitly disables BRP when PA-E is disabled. This already happens automatically under the surface, but we may soon change this. Context - In preparation for bringing `raw_ptr.h` into the standalone PA distribution, we are refactoring various GN args and variables. As part of this series of changes, we will combine the two separate BRP enablement switches in PA and in `raw_ptr.h`. This is done under the general assumption that nobody wants to compile support for BRP in one but not the other - so we might as well tie the support together in the same logical switch. However, we need to balance two contradictory cases: * In Chromium, most builders not using PA-E are also uninterested in using BRP. * _Outside Chromium_, embedders may wish to use BRP even without PA-E. The solution is to logically decouple PA-E usage from BRP usage. Although this CL is a no-op, it allows us to go under the hood and break the logical relation in a later CL without disrupting builds. Bug: 1371729 Change-Id: I21de0451b5a218c2f43b74f6fdd596f074b4545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005933 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1068957}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.