| commit | b06a60f64b10c6dd9e4ac30a1db97f3305c0c61e | [log] [tgz] |
|---|---|---|
| author | Nikhil Nayunigari <nikhilcn@google.com> | Fri Sep 29 17:21:57 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 29 17:21:57 2023 |
| tree | 958ba9f3f7d2dee929abcfa9b13e4a7e42799c00 | |
| parent | 9de047d4d2770cb94b240dfa7f512aaaf159ee9e [diff] |
Revert "[CrOS Network] Fix a bug where DHCP updates are overwriting user input" This reverts commit 78fd2e8de70b9383b55ce86aa5a578e7258e2af4. Reason for revert: This change introduced a regression that prevents network configuration in user configured networks to be set: https://b.corp.google.com/issues/299194723 Original change's description: > [CrOS Network] Fix a bug where DHCP updates are overwriting user input > > In cases where a user is updating static ip config, any updates observed > on the managed properties are automatically overwriting user input and > there by preventing user from completing the configuration of static ip. > > These changes prevent applications of changes observed on managed > properties if the ip config type is static. It allows application of > changes if a config doesn't exist and there after only allows changes to > be made by the end user. > > ./out/Default/browser_tests --gtest_filter='*NetworkIpConfig*' > > Bug: b/279207624 > Test: Tested manually on a DUT and through unit tests > Change-Id: I72bd56890a32c7bb8a9934f6e6f4e1bf839f3fab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575082 > Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com> > Reviewed-by: Gordon Seto <gordonseto@google.com> > Cr-Commit-Position: refs/heads/main@{#1156078} Bug: b/279207624 Change-Id: I0fa00f905adda5bbe30020888eb899e9bb8524b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4904746 Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com> Reviewed-by: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#1203345}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.