Ensure there is always an active tab in nonempty TabStripModels.

- CHECK (NotFatalUntil::M124 to prevent stability issues) this invariant
whenever the selection is changed or tabs are added/removed.
- Activate the first tab added to an empty tabstrip, even if that is not
requested by `add_types`.
- Update tests accordingly, and add a new one covering the first-tab
activation behavior.
- Fix a crash in tab dragging introduced by activating the first tab
added to an empty tabstrip.

The tab dragging crash occurred when dragging an initially collapsed
group out into a new window. In that case, the group is created
collapsed in the new window, and immediately expanded upon adding the
first, active tab. However, the order of notifications in the
TabStripModel is such that the group isn't yet created in the TabStrip
when it goes to expand it; this of course crashes. I sidestep this
problem by creating the new group already expanded, but the more
fundamental preexisting issue in how TabStripModel and TabStrip
communicate during group creation is out of scope for this CL.

Bug: 1496583
Change-Id: I58b70dc43424e5d3a3dc76215813d8355d70ff0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5166847
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243173}
3 files changed
tree: 3c2946d92324c8dfbc225233db02c1a7613d37f6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.