commit | b09eb612cb13398916d28342210018c609e887c6 | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Mon Apr 07 20:54:09 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 07 20:54:09 2025 |
tree | 57ff18952dec1f359a41ead41c15816e9a5fcbc1 | |
parent | fdd1a3cb7920a5837f901b3629362d57199f8cae [diff] |
Eliminate calls to SetOwnedByWidget(false). This is the default, so it's unnecessary, except for one issue: * BubbleDialogDelegate called SetOwnedByWidget(true), and two subclasses then overrode that back to false. Instead, remove the SetOwnedByWidget(true) call from BubbleDialogDelegate, and instead call SetOwnedByWidget(true) in all other subclasses and at all direct constructions. This will allow removing the bool arg in a subsequent change. Bug: 407812144 Change-Id: Id08da2d4888861aac262d317155059848b4c1120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435002 Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Andrea Gomez <andreaxg@google.com> Cr-Commit-Position: refs/heads/main@{#1443743}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.