Google Git
Sign in
chromium / chromium / src / 7493fb316508f52899f089d29b2e15ad65fdbce3
commit7493fb316508f52899f089d29b2e15ad65fdbce3[log] [tgz]
authornancylingwang <nancylingwang@chromium.org>Sat Aug 29 03:19:55 2020
committerCommit Bot <commit-bot@chromium.org>Sat Aug 29 03:19:55 2020
tree10ac79c4f9d8aa8a5433a19e85e9ed347dc6ff69
parent5b2f993b99e11f213653a3e54289834691b800dd [diff]
Fix the flaky unit test BuiltInAppTest.Build.

The new app icon factory code in AppService calls
display::Screen::GetScreen to get the scale, so in unit tests, sometime,
it crashes:
0x7f3430a96390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f)
#4 0x558ca24e91ea (anonymous namespace)::GetPrimaryDisplayScaleFactor()

Modify unit tests to set the TestScreen. Built bots run 20 times, and
there is no flaky tests for BuiltInAppTest.Build.

BUG=1115837

Change-Id: Id3ad017f5e15dbadfc6b28ef0d65295bfcc799b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379419
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802860}
1 file changed
tree: 10ac79c4f9d8aa8a5433a19e85e9ed347dc6ff69
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.