Google GitGoogle Git
Sign in
chromium/chromium/src/b0d97bbb4a1d751d7f8344121beaefca49fcf7af
commit
b0d97bbb4a1d751d7f8344121beaefca49fcf7af
[log]
author
Matt Menke <mmenke@chromium.org>
Thu Aug 21 16:49:00 2025
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Aug 21 16:49:00 2025
tree
9e46843ab3be75ec2cec0d3c28f5d7bdfa2af278
parent
b66d3f024a1866617a6410637fe1cfb781560e11 [diff]
Re-enable a pair of StaleHostResolverTests

In particular, StaleCache was disabled under santizers, and under
sanitizers, and StaleUsability under Windows. Both tests predate using
mock times, and the bug where StaleCache was disabled specifically
mentions changes in walltime causing entries in the stale cache to
expire being a potential issue. I'm guessing StaleUsability had the same
issue, but will monitor bots for a couple days to see if both tests are
flaky.

Also migrate StaleHostResolverTests to using
TaskEnvironment::TimeSource::MOCK_TIME instead of a TickClock to mock
out time. TaskEnvironment::TimeSource is more comprehensive and easier
to use that capability, though I plan to remove it in a followup CL,
once I'm confident this CL didn't introduce flake.

Bug: 41386419
Change-Id: I2dd355d30d450a86f439df2ff668b17d5e60bdea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6862454
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1504570}
1 file changed
tree: 9e46843ab3be75ec2cec0d3c28f5d7bdfa2af278
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.