Google Git
Sign in
chromium / chromium / src / b0def6201667f43558fd6a690cb71865c06d3efd
commitb0def6201667f43558fd6a690cb71865c06d3efd[log] [tgz]
authorHenrik Boström <hbos@chromium.org>Tue Mar 25 08:02:17 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 25 08:02:17 2025
treeadb7131c436efd4beee8e540d85fc4f0fc0f42f3
parentec8a4b94ae260721ce3944b7fabc921ab11d3a16 [diff]
H265: On Win/Intel only, trust the rate controller avoiding FPS issue.

If the track FPS suddenly drops (e.g. capture FPS reacting to lighting
conditions or dynamic FPS use cases), the WebRTC FrameDropper kicks in.
This suggests that it is sensitive to fluctuations that happen on this
HW and codec (this does not happen on other HW or other codecs).

Dropping the frame is the wrong thing to do though:
- The encoder FPS is temporarily close to 0 (see chromium:402910373).
- Not dropping does not cause overshoot according to getStats().

Luckily, WebRTC allows HW encoders to have their rate controllers be
trusted, disabling the FrameDropper. This fixes our problem.
- Fix is limited to Win/Intel/H265 to avoid accidental regressions on
  other HW.

Tested: manually using a test CL that periodically modifies capture
FPS[1] and my demo page[2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/6382318
[2] https://henbos.github.io/codec-quality/src/index.html

Bug: chromium:402910373
Change-Id: I08800d42ba317042a35cb147e69c9859cafb2b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387156
Reviewed-by: Jianlin Qiu <jianlin.qiu@intel.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437347}
1 file changed
tree: adb7131c436efd4beee8e540d85fc4f0fc0f42f3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.