Google Git
Sign in
chromium / chromium / src / b1407027d13bfe3b9e62c2f7aea4180db74681a9
commitb1407027d13bfe3b9e62c2f7aea4180db74681a9[log] [tgz]
authorXiaocheng Hu <xiaochengh@chromium.org>Mon Apr 25 23:04:44 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 25 23:04:44 2022
treebc0b2e006e31dfe487b837254c527ea5a17cb6d3
parent4da3ecb66a710165c2099605855f55e17c785af1 [diff]
[renderblocking] Dynamically inserted render-blocking stylesheets should not block scripts

This patch fixes a bug that adding `blocking=render` to script-inserted
stylesheets makes them script-blocking, which violates the spec as only
parser-inserted stylesheets can be script-blocking [1].

The fix idea is to add a new enum to PendingSheetType to represent
dynamic render-blocking sheets, so that we only block rendering but not
scripts or parser for this type.

This patch is also a preparation patch to allow unblocking rendering on
dynamic stylesheets by removing `blocking=render` [2]

[1] https://html.spec.whatwg.org/#contributes-a-script-blocking-style-sheet
[2] crrev.com/c/3601726

Bug: 1271296
Change-Id: I6eee34357ab034c802b3b022719427a1b3964c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601502
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995849}
11 files changed
tree: bc0b2e006e31dfe487b837254c527ea5a17cb6d3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.