commit | b141211e0c65628cf86a68a37d92377186560560 | [log] [tgz] |
---|---|---|
author | Dave Vandyke <kzar@chromium.org> | Thu Jan 12 18:53:46 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 12 18:53:46 2023 |
tree | 881c882c61188ae1e89557011bc3196189d9b3c9 | |
parent | 73e7b07a2ddc845d7b9dafe3d0c505a57ae21638 [diff] |
[DNR] Add rule filter for get dynamic/session rules APIs The declarativeNetRequest.getSessionRules and declarativeNetRequest.getDynamicRules APIs return a list of the extension's current declarativeNetRequest rules. Up to 5000 rules can be returned[1]. The rules are returned in an array not sorted by rule ID. Quite often, an extension will only need to inspect a specific rule. This is painful, since all returned rules need to be checked for the desired rule ID, until a match is found or the rules are exhausted. In the worst case, this means iterating through 5000 rules to find that the rule isn't present. Let's add an optional filter argument to the APIs that allows the caller to specify rule IDs to filter the results by. For the above example use-case, one rule ID can be specified at call time and then the length of the returned array can be quickly checked. 1 - https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/#property-MAX_NUMBER_OF_DYNAMIC_AND_SESSION_RULES Bug: 1379699 Change-Id: I36c7e7c841e4a864788ce7f6b17e5e7d275ca3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4059106 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Vandyke <kzar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1091956}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.