Google Git
Sign in
chromium / chromium / src / b158fe043ffd7d912cb4ee0122ec6ade06f163bc
commitb158fe043ffd7d912cb4ee0122ec6ade06f163bc[log] [tgz]
authorNoel Gordon <noel@chromium.org>Fri Dec 30 04:33:35 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 30 04:33:35 2022
tree2ded7e14c2cf64fff287e9f37975e8657b919315
parentc27b9fdada770fabfec5e3c87520118d4216bb8c [diff]
[quickview] Fix dark mode text content display

The quick view text content CSS forces a white background color,
which is fine in light mode.

In dark mode, the browser's default text color is `color: white`
and so white text on a (CSS forced) white background color makes
the text invisible (see bug).

Mitigate this: add `color: black` so text content displays black
text on `background-color: white` background.

Add a light/dark mode TODO: what colors should be used for text,
and background-color?

There is an existing QuickView integration test that checks that
the background-color is white for HTML. Note QuickView HTML also
uses the files_text_content.css file.

    "QuickView*openQuickViewBackgroundColorHtml*"

Bug: b/245855850
Test: browser_tests --gtest_filter=
Change-Id: I8be90744779759b5dc3119e21d4f0a0fc12d4a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4128264
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Ben Reich <benreich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1087714}
1 file changed
tree: 2ded7e14c2cf64fff287e9f37975e8657b919315
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.