commit | b161deb1a6731125547ed0dcb6693ce602772df1 | [log] [tgz] |
---|---|---|
author | Ari Chivukula <arichiv@chromium.org> | Wed Apr 02 16:05:52 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 02 16:05:52 2025 |
tree | 70ac63662c75c95166d7e5d9bacfc59b52992ed5 | |
parent | 2608207a96015700b75fe8e4529a3f5b22a60eb1 [diff] |
Revert "Dismiss modals when the Incognito Reauth screen is shown" This reverts commit 10da6425cadd05d884e246683ffb4988363cfdfd. Reason for revert: 407932146 Original change's description: > Dismiss modals when the Incognito Reauth screen is shown > > Prior to this CL, when the user had a modal showing above the Incognito > tab grid (for example a long-press context menu, a tab group > creation/edition view, etc.), that modal could still be shown above the > Incognito reauth screen (the view that hides the Incognito tabs when > reopening the app, when enabled). > > This CL adds a call to the ApplicationCommands handler to dismiss such > modals when the Incognito Reauth screen is shown. > > Validate-Test-Flakiness: skip > Fixed: 364861071 > Change-Id: I599b97868bf3172e6e1c965351f1a4fdb54dcfe6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387387 > Commit-Queue: Louis Romero <lpromero@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Auto-Submit: Louis Romero <lpromero@google.com> > Cr-Commit-Position: refs/heads/main@{#1441481} No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I59b76b4cce561058ca7ed25bbaadd2c86c333ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6426687 Owners-Override: Ari Chivukula <arichiv@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1441524}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.