commit | d8349349837694b60c3c18c3e0e79431f950aa64 | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Tue Mar 12 18:30:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 12 18:30:28 2019 |
tree | 7e6342d8a827cb6893155524cc3d6533f4c3668b | |
parent | 31b3400797158cc9f8840e1408f41df1ba845dd0 [diff] |
Fix keyboard focus on webpages after finishing window.print() with ESC. This is another variant of the issue fixed by r637595. Instead of pressing the cancel button in the Print Preview UI, users can press the ESC key instead. In this case, the sequence of events is different, and PrintPreviewDialogDelegate::OnDialogClosed() gets called too late. To fix this, add ui::WebDialogDelegate::OnDialogClosingFromKeyEvent(), and call it when the ConstrainedDialogWebView sees the ESC key being pressed. In PrintPreviewDialogDelegate::OnDialogClosingFromKeyEvent(), call OnDialogClosed() to properly unblock the webpage. BUG=936542 TEST=Manual, see bug. Change-Id: I0640ee7da86d407965ba6c6bbe3bbb17accf2ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515910 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#640026}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .