Bookmarks: Fix key handling regressions from Lit migration
(1) Fix issue with item and list handling the same key event, which led
to them cancelling each other out with Lit vs Polymer timing, by
not handling ctrl + space in the individual items.
(2) Fix related issue with the list key handler not always calling
e.stopPropagation() synchronously (meaning it would not have an
effect) by making the handler synchronous.
(3) Fix issue revealed by tests after fixing (2), where the document key
handlers in app mistakenly lost the capture setting when migrating
to EventTracker.
Also adding a regression test for (1).
Fixed: 415018776
Change-Id: I54f4289c85af1bdb85bcf14e2ebda31863437192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506365
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1455148}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.