commit | b1c32a2a41ea6cc5b865b1b256939aa615eb51bd | [log] [tgz] |
---|---|---|
author | Aaron Leventhal <aleventhal@google.com> | Tue Sep 03 13:43:26 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 03 13:43:26 2024 |
tree | c79502b43bd5c3bdc7fb883e62bfb61352b6e7c5 | |
parent | 702d29f3d4b30e9447ffa928931ca107bc247d2d [diff] |
[A11y] Fix regression and update support for aria-[row|col]indextext The original property was called aria-rowtext and aria-coltext and these were only supported because of an important use case in Sheets. This was non-standards and was implemented anyway (shame shame). This legacy support was broken via the HTML mode removal project, which broke announcements for cell names in Google Sheets by having HTML mode turned off by default on Windows. The reland of CL:5773586 to completely remove HTML mode would have likely fixed the Sheets issue but that stalled. A new reland is being worked on in CL:5827020 but it doesn't address the new HTML attribute or platform API object attribute names, and is too big/risky to merge into release branches. It's also notable that the Sheets regression should have caught by a test, but that test had been disabled due to flakes. This CL reenables it. As far as the new, longer HTML attribute names of aria-rowindextext and aria-colindextext, in CL:5577953 enough support was added to satisfy WPT tests but no platform mappings. This CL updates the support so that both old and new HTML attribute names are mapped to both the old and new object attribute names (per CORE-AAM). Eventually, once Sheets updates to use the new attribute names, the old HTML attribute names can be removed. The old object attribute names need to stay to keep JAWS/NVDA support. Fixed: 360904855,1061624 Bug: 339704201 Change-Id: Ia37fd01743d0426bba3a9c3cb4707c9dcae9a2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829307 Commit-Queue: Mark Schillaci <mschillaci@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Mark Schillaci <mschillaci@google.com> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350126}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.