Google Git
Sign in
chromium / chromium / src / b21f3c4c85ec0f7064f4c6b2c02499990da00e32
commitb21f3c4c85ec0f7064f4c6b2c02499990da00e32[log] [tgz]
authorAshley Newson <ashleynewson@chromium.org>Fri Jan 12 19:52:10 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 12 19:52:10 2024
treea143f21672d3e413eb219e6a301edca02416ab3e
parent5c584619aadd1111cafbe10e310c12005c9df3e3 [diff]
[Code Health] Avoid TabStatsTracker outliving local_state

TabStatsTracker contains a raw_ptr to pref_service, which would become
leaked dangling as TabStatsTracker was never destroyed, despite
various comments stating that pref_service must outlive it.

This change adds a PostDestroyThreads method to tear TabStatsTracker
down (mirroring its creation in PreCreateThreads).

This change also makes progress towards fixing a leaked dangling
pointer in components/metrics/daily_event.h, but does not fix all
additional cases unrelated to TabStatsTracker.

Bug: 1462034
Bug: 1462055
Change-Id: I78e61c663da2d21110da06dd1f9cc98d22e2a1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5089188
Commit-Queue: Ashley Newson <ashleynewson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Reviewed-by: Olivier Li Shing Tat-Dupuis <olivierli@google.com>
Cr-Commit-Position: refs/heads/main@{#1246613}
9 files changed
tree: a143f21672d3e413eb219e6a301edca02416ab3e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.