Experiment with disabling async navigation interception Launched in 2019, the AsyncNavigationIntercept feature causes ExternalNavigationHandler to evaluate whether the navigation should instead launch an app to run in parallel to the navigation. This optimization is incorrect, because if the redirect arrives before the initial navigation is evaluated, we just evaluate the redirect URL twice and forget about the initial URL. There's no trivial way to fix this as the NavigationHandle is mutated throughout the navigation and you can't copy a NavigationHandle. We should run an experiment to see how much this optimization actually helps in practice these days, and consider unlaunching it for correctness and complexity reasons. Bug: 381535042 Change-Id: Ida86546851cc7bd7131130027820b95ad8db4450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055004 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1390460}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.