Google Git
Sign in
chromium / chromium / src / b272e3451766d3cc2edfb25ba8d74e863081c47c
commitb272e3451766d3cc2edfb25ba8d74e863081c47c[log] [tgz]
authorClemens Backes <clemensb@chromium.org>Wed Mar 26 17:30:51 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 26 17:30:51 2025
treedb87beb9ebfb87dfd4ced8422168483b5404ddfb
parentde01803179452331ef307118e2514016f66a5521 [diff]
[gin] Enter the isolate before deleting a context

Deleting the context writes to the external pointer table and to the
heap, hence we must enter the isolate before deleting the context.

This is blocking a new DCHECK in v8: https://crrev.com/c/6387098

For consistency, we should also move the HandleScope from the
`PerContextData` destructor to the `ShellRunner` destructor, but this
causes failures in other users of `PerContextData`, so this is left for
a follow-up CL.

Drive-by cleanup: Remove `using` declarations which were mostly not
used, and if they were then inconsistently.

R=mlippautz@chromium.org

Bug: 396607238
Change-Id: I110a72c047d3a719e9606fc98f32f2b0536bb656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394240
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438234}
1 file changed
tree: db87beb9ebfb87dfd4ced8422168483b5404ddfb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.