Google Git
Sign in
chromium / chromium / src / b29dcdb2969d1428dc9bc8fe672e7b14ecf3258b
commitb29dcdb2969d1428dc9bc8fe672e7b14ecf3258b[log] [tgz]
authorJohn Delaney <johnidel@chromium.org>Tue Nov 14 01:19:23 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 14 01:19:23 2023
tree5088984f8f236312c5bade6a4dde815bb682ed76
parent373e681b2e93c6c4c3af43143d1424139cf1b32d [diff]
[120] Tag subframe navs for ad third party cookie deprecation access metrics

https://chromium-review.googlesource.com/c/chromium/src/+/4983468
tagged all subresource cookie accesses with a bit indicating whether
the request was used for advertising purposes.

Subframe navigations resources do not use the blink side loading
infra, so they need to be tagged in the browser process to get
coverage.

In order to properly tag the initial ResourceRequest for the
navigation, we need to also turn off an optimization that parallelizes
the first LoadPolicy calculation and navigation start in dry run
mode. This is kept behind a feature flag.

The existing nav handle API,
GetNavigationInitiatorActivationAndAdStatus(), is not sufficient
as we need to include signals outside of the initiator, and currently
the ad status is only propagated with user activation in this signal.

(cherry picked from commit 4cf7d6ea8648d4c68575755a4fe869dbb8b810dc)

Bug: 1500290
Change-Id: I4488bf230d798aeb2bfd92a03ddac950cda75977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995611
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1222364}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5026136
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#630}
Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
16 files changed
tree: 5088984f8f236312c5bade6a4dde815bb682ed76
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.