Google Git
Sign in
chromium / chromium / src / b3291c9c757c766f3951b8dd4fbff35d00fdb1f9
commitb3291c9c757c766f3951b8dd4fbff35d00fdb1f9[log] [tgz]
authorJames Cook <jamescook@chromium.org>Thu Mar 14 19:51:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 14 19:51:54 2024
tree9f7cfdcc7f8d807e947221d20c29d0f24869a2fa
parentd371a8d4b24179c44e868c8e1e3bfc009c44deec [diff]
birch: Fix weather not loading sometimes on initial display

Loading weather requires a network request to a backend service that
requires auth tokens. Ensure that the user's refresh tokens are
available before attempting to make a weather fetch.

This requires access to IdentityManager, so plumb it from ash into
chrome via BirchClient. Add a helper RefreshTokenWaiter class. A future
CL will adapt BirchCalendarFetcher to use the waiter, since it has the
same issue with refresh tokens.

Bug: b:329324098
Test: added to ash_unittests and unit_tests
Change-Id: Ia415a38c786dc9b51cd2ee0fcee8568b7d661ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369760
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273001}
14 files changed
tree: 9f7cfdcc7f8d807e947221d20c29d0f24869a2fa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.