commit | b3477beb5ad65b28ac7c539cd94f709f777f9aed | [log] [tgz] |
---|---|---|
author | Mike Wasserman <msw@chromium.org> | Fri Mar 15 18:00:45 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 15 18:00:45 2019 |
tree | a39b37095f4c32eb4b488895963ba857c043e10f | |
parent | 2697f592ef0be9b2c4b7c501a481f11e85accfca [diff] |
views: Store the global set of desktop capture clients as weak pointers This supports destruction of capture clients during the SetCapture loop. Cached pointers should be invalidated when objects are destroyed mid-loop. After crrev.com/1506570, StatusBubbleViews destroys itself when hidden. Context menus take capture from browsers, destroying the bubble and its capture client mid-loop. Bug: 938127 Test: No status bubble UAFs when right-clicking links. Change-Id: I147fc880410e216864699595a983c592ec84f040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525408 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#641225}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .