commit b3997225501112f1861492a311ae56ab64796911
author Owen Wiggins <owx@chromium.org> Fri Oct 22 00:24:19 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 22 00:24:19 2021
tree 5498f4410441641ef5abd3c35ec0a7c4f77175cd
parent 5bd64d091131f8f797f9103c930b9ec4bc8e285b

Revert "Close Message Center Bubble asynchronously in destructor."

This reverts commit 56118287fa30280c1b841c45252fcef385b24d7d.

Reason for revert: Discovered there is one remaining crash case.

Original change's description:
> Close Message Center Bubble asynchronously in destructor.
>
> The Message Center and Quick Settings UI are peers owned by the Unified
> System Tray. Previously, when all notifications in the Message Center
> were removed, the Message Center would be in an unusual state - it would
> be hidden, but still active and focused. When the Esc accelerator is
> processed by the focus manager of the Unified System Tray, it would free
> the Message Center Bubble and close the widget synchronously from the
> destructor, causing NativeWidgetAura to fail when the Window properties
> are accessed after it has been freed from the heap.
>
> This fix changes the Message Center Bubble destructor to asynchronously
> close its widget. This retains the Widget after the
> NativeWidgetAura::Hide() call in NativeWidgetAura::Close(), preventing
> the window_ pointer from becoming invalid. The remaining logic for
> next/previous focusable already handles this state correctly -it won't
> focus the Message Center with Tab or Shift+Tab.
>
> Bug: 1251351
> Change-Id: I924c222c4bbfe08ea7a3e620531cee92d70596b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207232
> Commit-Queue: Owen Wiggins <owx@chromium.org>
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#934031}

Bug: 1251351
Change-Id: I319c15848f5f3c0cae74bf90b2738516111c2717
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3238033
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Owen Wiggins <owx@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#934106}