| commit | b39cb46f1a78430405b38e56fe4bc50a01e00c00 | [log] [tgz] |
|---|---|---|
| author | Ed Chin <edchin@google.com> | Fri May 20 21:31:57 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 20 21:31:57 2022 |
| tree | ef06c142ad17ee679a52e14fd3933115a44c551c | |
| parent | 7aa3350b54d40d79c1aa8973015e3ad65053d2f1 [diff] |
[M103][ios][ConfirmationAlertViewController] Add option to enclose image in view with shadow and badge Previous uses of ConfirmationAlertViewController use an image that already has a shadow baked into the image. In FirstFollowViewController, we want to be able to set a favicon image inside a frame view that has a shadow. These favicons will not already have a shadow. Furthermore, we want a green checkmark badge on the upper right corner. New screenshots: https://screenshot.googleplex.com/3pVdiNyHhwW4tzv.png https://screenshot.googleplex.com/4QzpmWf3uRfEXZ9.png https://screenshot.googleplex.com/4hgqHKo4te2UWko.png https://screenshot.googleplex.com/9w5DkS82yNuWSsW.png https://screenshot.googleplex.com/tjSscgwCB24NAjh.png https://screenshot.googleplex.com/BzgXFprpyFpzZGu.png This CL has not affected existing uses of ConfirmationAlertViewController. Existing uses of ConfirmationAlertViewController screenshots: https://screenshot.googleplex.com/6PU9B6LkgFqKfQh.png https://screenshot.googleplex.com/3CD9LkaiqY3uC67.png https://screenshot.googleplex.com/5bj8TwAFVHgyiH8.png https://screenshot.googleplex.com/3bZg6Lu6gF9QZ9o.png (cherry picked from commit ba21cfb514060953f44c61885f2c4022aabfbed3) Bug: 1327057 Change-Id: I82dc1556bc49d6fc411109f07ee2b01b32b0545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649311 Commit-Queue: edchin <edchin@google.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1005278} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656109 Cr-Commit-Position: refs/branch-heads/5060@{#144} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.
