Google Git
Sign in
chromium / chromium / src / b3ad4d3f7ceb6920cefb5b411d4ebd3f7e2e9698
commitb3ad4d3f7ceb6920cefb5b411d4ebd3f7e2e9698[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Wed Aug 09 17:30:18 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Aug 09 17:30:18 2023
tree0fdb19547e0da9ca4a4388045b6a0b129c764357
parent2205835b5d8b73b86549b285b4e257a4f2a8fcf9 [diff]
[min-font-size] Stop localizing "Minimum font size"

This patch stops localized default value for the ""Minimum
font size."

This feature was originally introduced for the readability on
high-DPI devices and for the accessibility, and it was
localized. But then it was turned to the accessibility feature,
therefore localization is no longer needed.

This patch stops doing it because the localization of this
setting is causing interoperability and accessibility issues.

Please see more details and the discussion with the i18n team
in the design doc:
https://docs.google.com/document/u/1/d/180f-ex4Nj11lExg80ziZZ8Bc-LxQU6B9wY-WEZksLM0/edit?usp=sharing

The Intent to Ship thread:
https://groups.google.com/a/chromium.org/g/blink-dev/c/QpQeCiNGhDs/m/LNQlYXcmAwAJ

Manually tested a local build:
* Without this patch, and restart after switching to Japanese
  UI, it's 10.
* Build with this patch, it becomes 0.
* With this patch and run with the option:
    `--disable-features=UnlocalizeMinimumFontSize`
  it's 10.

Bug: 1469490
Change-Id: I5149beaeff541ea3b132be8739f12ef7d1eacdf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4764565
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1181565}
1 file changed
tree: 0fdb19547e0da9ca4a4388045b6a0b129c764357
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.