commit | b3b386b5f4f0dd757ff5d4a34fb978265bcb7fe3 | [log] [tgz] |
---|---|---|
author | Travis Skare <skare@chromium.org> | Thu Sep 23 23:44:11 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 23 23:44:11 2021 |
tree | 609e9de21e5e315ab98654fa022638c220321781 | |
parent | f8fbc236a52f29fce7dbd6abec80c68199b46586 [diff] |
[LongScreenshots] Auto-scroll view when dragging at edge of screen. This is slightly janky in that in practice the user will have to perform a drag gesture across the bounds of the imageview, potentially a few times to scroll the view to the desired place. However, ideally that makes it more obvious the view is scrollable and they can use the preferable, traditional, ImageView native scroll support; landing this so we can experiment with it and discuss, since it's our remaining P1. This approach could potentially be smoothed by having a timer and auto-scrolling+auto-repositioning the mask every N milliseconds, but that is more fragile across devices and the failure modes are harder to catch (scrolling too fast, for example) Fixes: 1249219 Change-Id: I5aa67688bfa06b2c053752d2ef9fd24f42e2c9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177421 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/main@{#924543}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.