Google Git
Sign in
chromium / chromium / src / b40ec612a0463079a019164a3b27ec9d6dc8ba49
commitb40ec612a0463079a019164a3b27ec9d6dc8ba49[log] [tgz]
authordpapad <dpapad@chromium.org>Tue Jun 11 22:05:14 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 11 22:05:14 2024
tree1681ceed86fa0903279f28c6e1b9a6ddbbae112b
parent6ecb18ec5a9b4f2960b4c6fabac663203f5f9422 [diff]
WebUI: Throw error when cr-icon encounters unknown iconsets.

In order to make this possible the following changes had to be made:

 - Modify iron-iconset-svg to synchronously fire 'iron-iconset-added'
   events.
 - Modify iconset_map.ts to lazily instantiate the singleton instance,
   and to account for any iron-iconset-svg instances added before the
   singleton instance is created.
 - Update various tests that used non-existing iconsets to use existing
   ones.
 - Removed obsolete test cases from cr-icon tests.
 - Added dedicated iconset_map.ts tests.

Bug: 346386724
Change-Id: I2bf247d047885c0a5b76bbebd1d527a42d83da4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5609954
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313700}
13 files changed
tree: 1681ceed86fa0903279f28c6e1b9a6ddbbae112b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.