commit b420423bc2ac9184759d2907733c8bf168580490
author rajendrant <rajendrant@chromium.org> Fri Jun 28 19:25:45 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 28 19:25:45 2024
tree 2ed30559b2c30b210350c0a3412c774c5798b71f
parent 4fa1ef846f85a9dd18c24e264413a53b6b9cfce2

Reland "Use database as cache for passages and embeddings to bypass embedder"

This is a reland of commit 22c986f0ce1a5ef2efa704a2093a4d47eb18a63e

The feature param to use database before embedder is turned off by default to avoid the https://crbug.com/347685218 crash. I will continue debug the crash.

Original change's description:
> Use database as cache for passages and embeddings to bypass embedder
>
> This CL saves the embedder from having to recompute embeddings for
> passages that are already stored in the database when a visit is
> made to the same URL. Instead of computing the embedding with the
> model, the stored embedding is reused.
>
> Additionally, this CL adds histogram logging for cancellation of
> passage extraction, embedding, and storage. Various reason codes
> are logged so we can identify the step at which cancellation occurred.
> The tab helper should dominate, but later cancellation in the service
> might signal problems or opportunities to optimize.
>
> Also, this CL fixes b/347306992 using live loading tab count
> instead of a member value updated via notifications that could
> be missed when a loading tab is closed. (Random bug noticed during
> development.)
>
> Bug: 345819418
> Change-Id: Icaacf456717b9d88c0e14b3c8f3a1e31835440c6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5629651
> Commit-Queue: Orin Jaworski <orinj@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Reviewed-by: Orin Jaworski <orinj@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1315485}

Bug: 345819418
Change-Id: I3e15c76133ef60add563224ebb2dcbb4c0ca5cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5656278
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Raj T <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321126}