Google Git
Sign in
chromium / chromium / src / b4336921c6e3b2fc047340dd451e8313967eea1d
commitb4336921c6e3b2fc047340dd451e8313967eea1d[log] [tgz]
authorTom Lukaszewicz <tluk@chromium.org>Mon May 23 19:56:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 23 19:56:50 2022
tree9da84174290d0a18883481d677b562ef24c44aef
parenta6a90a050b8194525de0ae6ca1363de10b03f091 [diff]
[M103 Merge][side search] Add per-tab, per-window and per-profile label triggers

This CL adds per-tab, per-window and per-profile triggering for the
SideSearchIconView's label text in the omnibox.

This expands on the current setting which is fixed at per-profile.
This CL gates the various options behind a feature flag and sets
the per-window setting as default.

Test with
--enable-features=SideSearch,SideSearchDSESupport,SidePanelImprovedClobbering,SideSearchPageActionLabelAnimation:SideSearchPageActionLabelAnimationFrequency/OncePerWindow

(cherry picked from commit c9e42d4ea95cd50049457aa1bb18db0c4f843a8d)

Bug: 1325511
Change-Id: I6b934dd1b0e88361d7b24c7d888355ccb2de26c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648394
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004556}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661364
Cr-Commit-Position: refs/branch-heads/5060@{#194}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
7 files changed
tree: 9da84174290d0a18883481d677b562ef24c44aef
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.