commit b439ff333b4b0edf49378e01c54f31bef88b51a7
author Orko Garai <orko@igalia.com> Fri Dec 01 00:27:55 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 01 00:27:55 2023
tree 46b8b118ebfd23cb910f167e021b0c642ee48ef1
parent 67424279771b697b6c79ae232766aabe1c870f96

[linux/wayland] Fix wrong size extension menu

The wayland window always returns 0,0 as position because in Wayland we
don't know the position of the window in the screen.

As a result `anchor_rect` and `screen_rect` in
BubbleDialogDelegate::GetMaxAvailableScreenSpaceToPlaceBubble would not
be accurate in regular Wayland compositors, i.e. the position of
`anchor_rect` ends up being ~= the position of the anchor view in the
window instead of position in the screen as is the case with X11, while
`screen_rect` ends up being the rect for whichever display is found
nearest to that potentially erroneous `anchor_rect` value.

In multi-display setups this is exaggerated in certain cases as reported
with some specific relative positioning of displays where the nearest
display returned is wrong and/or `screen_rect` does not contain
`anchor_rect`, causing the available space calculation to be negative
and forced to be zero. This makes the extension popup use the `kMinSize`
value of 25 which is why we see the narrow width.

So remove the usage of
BubbleDialogDelegate::GetMaxAvailableScreenSpaceToPlaceBubble and just
using the default `kMaxSize` (800x600) in those platforms which would
fix the max value mistakenly being set to 25 when the function returns 0
and for the most part behave similar to non-reproducible cases where the
function doesn't return a zero value, because in most other cases it
just happens to return a size equal to or bigger than the default which
then gets clamped to the default dimensions anyway.

Fixed: 1282790
Change-Id: I588069042cd8321d7100fc174440bc2dce3b7d6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069774
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Orko Garai <orko@igalia.com>
Reviewed-by: Max Ihlenfeldt <max@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1231642}