| commit | b458c06702ce7c4e3342375235d7454f6084a20c | [log] [tgz] |
|---|---|---|
| author | Lei Zhang <thestig@chromium.org> | Wed Dec 11 18:44:40 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 11 18:44:40 2024 |
| tree | 12a2306b73a5317549d8a84d6f7d46fccadfd6da | |
| parent | 0b412dcc122f7bf2a6c8e146886a5129660b48e5 [diff] |
Fix various nits in save_page_browsertest.cc - Modernize by using std::make_unique() and the auto keyword. - Remove unnecessary variables and duplicate logic. - Consistently use size() instead of length(). - Consistently use size_t with size. Update expected counts to size_t to match. Make constants const along the way. - Consistently use ASSERT_EQ() to check the size before continuing, to prevent potential out of bound errors. Change-Id: I1ea9a119948a3b06394fff7e86b91a8e453c0e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6086877 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1394960}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.