commit b45fcac3e32dfd2495b25137da18aeeb20e6f14c
author Jenny Zhang <jennyz@chromium.org> Thu Dec 14 17:52:29 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Dec 14 17:52:29 2023
tree 835111ef38c5e6879ab61a76e138bb67e25ae595
parent 57a5dfae28e4f9e0246a004f507fba2daf4bc650

Lacros-Test: Skip crosapi version check if already supported in ash.

This is a follow up cl for crrev.com/c/5117919.

Due to an issue with some tests improperly calling
BrowserInitParams::SetInitParamsForTests in test
Setup() which wipes out interceface_versions data
in BrowserInitParams, when IsTestControllerAvailable()
is called in browser_test_util to check if a TestControl
method is supported in ash, it failed incorrectly(the method is
available in all ash channels). This issue blocks another pending cl(crrev.com/c/5068434) since it calls browser_test_util::WaitForWindowCreation from
InProcessBrowserTest:: PreRunTestOnMainThread() and will
failed in IsTestControllerAvailable() for those tests which
wipes out BrowserInitParams::interface_versions by calling BrowserInitParams::SetInitParamsForTests. There
is already an ongoing effort to fix the root cause of
BrowserInitParams::SetInitParamsForTests issue, but it will
take some time to land that cl.

As a workaround to unblock crrev.com/c/5068434, this cl
removes the code for handling version skew if
the crosapi method already supported by all ash channels.
Instead, we validate if TestController is available in
LacrosService before calling crosapi. When test code calls
the apis in browser_test_utils to wait for UI elements to be
created in ash, ash should be available. If ash is not available
for some reason, it may expose some real problem to be fixed.
This should be handled differently than the cases in which
the crosapi is not supported in ash or the operation times out
(The existing code returns false for all these cases). Now the functions
fail with CHECK if ash is not available, and return false if crosapi
is not supported by ash or times out.

I patched crrev.com/c/5068434 with this cl and it passes CQ
run(crrev.com/c/5121452).


Bug: NONE
Change-Id: I5d4cc186df54083750c10c90d6ee7e18bbff46eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5120010
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1237592}